Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment frontend test files #21947

Merged
merged 11 commits into from
Aug 18, 2023
Merged

Uncomment frontend test files #21947

merged 11 commits into from
Aug 18, 2023

Conversation

mosesdaudu001
Copy link
Contributor

The only 4 frontends that do not yet have a testing pipleine are scipy, pandas, onnx and mindspore. So I have added the @pytest.mark.skip("Testing pipeline not yet implemented.") to their corresponding tests

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

AnnaTz
AnnaTz suggested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some more tests for scipy. Kindly update those too. Thanks!

AnnaTz
AnnaTz approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@AnnaTz AnnaTz merged commit 656f460 into ivy-llc:main Aug 18, 2023
111 of 132 checks passed
@mosesdaudu001 mosesdaudu001 deleted the uncomment_frontend_test_files branch August 18, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz approved these changes

Assignees

@tomatillos tomatillos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosesdaudu001 @AnnaTz @tomatillos